Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

Fix: char-subscripts warnings#1591

Merged
dragonmux merged 1 commit intoblackmagic-debug:mainfrom
perigoso:fix/warning-char-subscripts
Aug 14, 2023
Merged

Fix: char-subscripts warnings#1591
dragonmux merged 1 commit intoblackmagic-debug:mainfrom
perigoso:fix/warning-char-subscripts

Conversation

@perigoso
Copy link
Copy Markdown
Contributor

Detailed description

Fix warnings for -Wchar-subscripts

See #1590 for context

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@perigoso perigoso mentioned this pull request Aug 10, 2023
43 tasks
@dragonmux dragonmux added the Enhancement General project improvement label Aug 13, 2023
Copy link
Copy Markdown
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! There's a small suggested change to look at and then with that sorted, we're happy to merge this.

@dragonmux dragonmux added this to the v1.10 milestone Aug 13, 2023
@perigoso perigoso force-pushed the fix/warning-char-subscripts branch from 43e8702 to d733a4f Compare August 14, 2023 16:53
Copy link
Copy Markdown
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging!

@dragonmux dragonmux merged commit d5c3fb3 into blackmagic-debug:main Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Enhancement General project improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants