Skip to content

Conversation

@mainawycliffe
Copy link
Contributor

@mainawycliffe mainawycliffe commented Oct 30, 2019

Add a FindFiles func that will find files recursively in all directories (#35)

NOTE:

I wanted the method to accept glob, but its behaving strangely in go. When you pass dir/**/*.txt, it only finds files inside the subdirectories ignoring all files in the root directory.

@bitfield
Copy link
Owner

Are you ready for a review yet @mainawycliffe or are you still working on it?

@mainawycliffe
Copy link
Contributor Author

I am ready for a review. I think we can add glob to FindFile func if the situation changes in the future.

Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mainawycliffe! This looks great. Just a few nitpicks I've pointed out.

Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mainawycliffe
Copy link
Contributor Author

I am Sorry, I accidentally merged my branch on #23 and became too tangled to undo. I think the example is also for a review, so you can take a look at that too.

Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Everything with the FindFiles feature is complete, I think, so it's just finalising the details of the todos example now.

@mainawycliffe
Copy link
Contributor Author

I have created a new repo for the find Todos program here. This is actually a good idea, as I can work to improve it and improve comment detection on the repo.

Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mainawycliffe! Sorry it's taken me a while to get to this. Work is interfering with my open source activities!

mainawycliffe and others added 2 commits December 6, 2019 20:36
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
@mainawycliffe
Copy link
Contributor Author

no problem @bitfield, that happens all the time.

Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple of minor tweaks to give this the final polish!

Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
@mainawycliffe
Copy link
Contributor Author

Taken care of the changes requested above.

@bitfield
Copy link
Owner

Great work, @mainawycliffe! Do you mind if I give this a final pass for style, consistency, squash commits, etc?

@mainawycliffe
Copy link
Contributor Author

No, I don't.

@bitfield bitfield merged commit 59e0e71 into bitfield:master Mar 30, 2020
@bitfield
Copy link
Owner

Thanks again for the feature, and all your patient collaboration @mainawycliffe.

@mainawycliffe
Copy link
Contributor Author

Thanks too, learned a lot. Any new issue that I can work on?

@bitfield
Copy link
Owner

I think what we could most use is some substantial, non-trivial, useful programs written using script. If they're easy to write, they'll make great examples and demos. If they're not, that may be pointing us towards improvements and additions in script that would make such programs easier. See what you can come up with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants