Repository navigation
Fix “JSON.parse: unexpected character” when hovering links in Firefox… - #9
Open
alfredohernandezinostroza wants to merge 1 commit into
Open
alfredohernandezinostroza wants to merge 1 commit into
alfredohernandezinostroza wants to merge 1 commit into
Conversation
… 157.0 In recent Firefox versions, hovering an internal link threw SyntaxError: JSON.parse: unexpected character. The script only recognized named destinations from getDestinations() and JSON-encoded explicit destinations, but the viewer can also produce other link formats such as #page=N&zoom=... and #nameddest=.... Changes: Resolve all link formats: JSON destinations, nameddest=, page=/zoom=, and plain named destinations, using getDestination(). Fall back to getPageIndex() when cachedPageNumber() has no cached value. Take the vertical position for FitH/FitBH/FitR destinations from the correct arguments, and stop treating FitV/FitBV arguments as a vertical position. Find the hovered link with closest(), so elements with no offsetParent no longer throw. Log links that can’t be resolved instead of throwing, and clean up properly if the mouse leaves before the preview renders. Tested in Firefox 157.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… 157.0
In recent Firefox versions, hovering an internal link threw SyntaxError: JSON.parse: unexpected character. The script only recognized named destinations from getDestinations() and JSON-encoded explicit destinations, but the viewer can also produce other link formats such as #page=N&zoom=... and #nameddest=....
Changes:
Resolve all link formats: JSON destinations, nameddest=, page=/zoom=, and plain named destinations, using getDestination(). Fall back to getPageIndex() when cachedPageNumber() has no cached value. Take the vertical position for FitH/FitBH/FitR destinations from the correct arguments, and stop treating FitV/FitBV arguments as a vertical position. Find the hovered link with closest(), so elements with no offsetParent no longer throw. Log links that can’t be resolved instead of throwing, and clean up properly if the mouse leaves before the preview renders.
Tested in Firefox 157.0