Skip to content

FIX: Alternative to leaflet.extras#364

Merged
ateucher merged 4 commits intomainfrom
fix/drop-dep
Feb 6, 2026
Merged

FIX: Alternative to leaflet.extras#364
ateucher merged 4 commits intomainfrom
fix/drop-dep

Conversation

@boshek
Copy link
Collaborator

@boshek boshek commented Feb 6, 2026

This works equally well. Closes #363

Test failure is unrelated but "fixing" here. It's not run on CRAN so that's why we've not noticed it before.

@boshek boshek requested a review from ateucher February 6, 2026 02:09
@ateucher
Copy link
Collaborator

ateucher commented Feb 6, 2026

Hah sorry I didn't see this before I pushed #365! Yours is simpler and doesn't add htmltools, but I also tweaked another test, let's take the best of both and keep them in this PR

@ateucher ateucher mentioned this pull request Feb 6, 2026
@ateucher ateucher merged commit 81891d1 into main Feb 6, 2026
4 of 5 checks passed
@ateucher ateucher deleted the fix/drop-dep branch February 6, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRAN request]: Remove dependency on leaflet.extras

2 participants