Skip to content

Conversation

@bashtage
Copy link
Owner

@bashtage bashtage commented Jan 8, 2020

Add McElroy's measure and Berndt's measure
Clarify overall is Judge's measure

Add McElroy's measure and Berndt's measure
Clarify overall is Judge's measure
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #225 into master will decrease coverage by 0.01%.
The diff coverage is 99.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage    99.7%   99.69%   -0.02%     
==========================================
  Files          83       82       -1     
  Lines       14450    14537      +87     
  Branches     1420     1434      +14     
==========================================
+ Hits        14408    14493      +85     
  Misses         11       11              
- Partials       31       33       +2
Impacted Files Coverage Δ
...nearmodels/tests/system/test_3sls_against_stata.py 100% <ø> (ø) ⬆️
linearmodels/tests/system/test_gmm.py 98.38% <ø> (ø) ⬆️
linearmodels/tests/test_utility.py 100% <ø> (ø) ⬆️
linearmodels/tests/system/test_utility.py 100% <ø> (ø) ⬆️
linearmodels/tests/system/test_formulas.py 100% <ø> (ø) ⬆️
linearmodels/tests/system/test_sur.py 100% <ø> (ø) ⬆️
linearmodels/tests/system/test_equivalence.py 100% <ø> (ø) ⬆️
...inearmodels/tests/system/test_sur_against_stata.py 100% <ø> (ø) ⬆️
linearmodels/tests/system/test_3sls.py 100% <ø> (ø) ⬆️
linearmodels/tests/test_examples.py 100% <ø> (ø) ⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00392cf...8e38cc4. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jan 9, 2020

Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 123:57: E203 whitespace before ':'
Line 193:27: E203 whitespace before ':'
Line 210:36: E203 whitespace before ':'
Line 310:57: E203 whitespace before ':'

Line 633:38: E203 whitespace before ':'
Line 1020:32: E203 whitespace before ':'
Line 1023:32: E203 whitespace before ':'

Line 90:20: E203 whitespace before ':'
Line 102:27: E203 whitespace before ':'
Line 999:53: E203 whitespace before ':'

Line 185:35: E203 whitespace before ':'
Line 186:17: E203 whitespace before ':'
Line 278:50: E203 whitespace before ':'

Line 212:26: E203 whitespace before ':'
Line 212:60: E203 whitespace before ':'
Line 513:22: E203 whitespace before ':'

Line 185:22: E203 whitespace before ':'
Line 291:22: E203 whitespace before ':'

Line 647:31: E203 whitespace before ':'
Line 804:25: E203 whitespace before ':'
Line 849:22: E203 whitespace before ':'
Line 858:47: E203 whitespace before ':'
Line 1108:21: E203 whitespace before ':'
Line 1115:31: E203 whitespace before ':'
Line 1115:47: E203 whitespace before ':'
Line 1126:38: E203 whitespace before ':'
Line 1175:25: E203 whitespace before ':'
Line 1205:18: E203 whitespace before ':'
Line 1741:25: E203 whitespace before ':'
Line 1769:29: E203 whitespace before ':'
Line 1787:25: E203 whitespace before ':'
Line 1983:30: E203 whitespace before ':'

Line 34:21: E203 whitespace before ':'
Line 50:41: E203 whitespace before ':'

Line 67:31: E203 whitespace before ':'
Line 82:36: E203 whitespace before ':'
Line 105:24: E203 whitespace before ':'
Line 105:45: E203 whitespace before ':'
Line 175:31: E203 whitespace before ':'
Line 190:36: E203 whitespace before ':'
Line 213:24: E203 whitespace before ':'
Line 213:45: E203 whitespace before ':'
Line 215:44: E203 whitespace before ':'
Line 215:65: E203 whitespace before ':'
Line 283:31: E203 whitespace before ':'
Line 298:36: E203 whitespace before ':'
Line 321:24: E203 whitespace before ':'
Line 321:45: E203 whitespace before ':'
Line 323:44: E203 whitespace before ':'
Line 323:65: E203 whitespace before ':'

Line 76:42: E203 whitespace before ':'
Line 78:37: E203 whitespace before ':'
Line 82:17: E203 whitespace before ':'
Line 83:17: E203 whitespace before ':'
Line 86:25: E203 whitespace before ':'
Line 86:60: E203 whitespace before ':'
Line 109:22: E203 whitespace before ':'
Line 109:39: E203 whitespace before ':'
Line 109:49: E203 whitespace before ':'
Line 109:66: E203 whitespace before ':'

Line 20:15: E203 whitespace before ':'
Line 24:23: E203 whitespace before ':'

Line 59:31: E203 whitespace before ':'
Line 70:36: E203 whitespace before ':'

Line 27:4: E203 whitespace before ':'
Line 27:27: E203 whitespace before ':'
Line 33:11: E203 whitespace before ':'
Line 55:8: E203 whitespace before ':'
Line 55:32: E203 whitespace before ':'

Line 52:15: E203 whitespace before ':'

Line 34:15: E203 whitespace before ':'

Line 33:15: E203 whitespace before ':'

Line 54:45: E203 whitespace before ':'

Line 224:29: E203 whitespace before ':'
Line 225:34: E203 whitespace before ':'

Line 166:44: E203 whitespace before ':'
Line 181:42: E203 whitespace before ':'

Line 65:49: E203 whitespace before ':'

Line 103:16: E203 whitespace before ':'
Line 103:31: E203 whitespace before ':'
Line 104:16: E203 whitespace before ':'
Line 105:22: E203 whitespace before ':'
Line 105:46: E203 whitespace before ':'
Line 110:26: E203 whitespace before ':'
Line 110:56: E203 whitespace before ':'
Line 116:54: E203 whitespace before ':'
Line 121:32: E203 whitespace before ':'
Line 122:38: E203 whitespace before ':'
Line 123:31: E203 whitespace before ':'
Line 234:22: E203 whitespace before ':'
Line 265:32: E203 whitespace before ':'
Line 366:20: E203 whitespace before ':'
Line 366:42: E203 whitespace before ':'
Line 374:20: E203 whitespace before ':'
Line 374:42: E203 whitespace before ':'

Line 21:31: E203 whitespace before ':'
Line 22:38: E203 whitespace before ':'

Line 35:32: E203 whitespace before ':'
Line 39:35: E203 whitespace before ':'

Line 81:24: E203 whitespace before ':'
Line 81:40: E203 whitespace before ':'
Line 157:26: E203 whitespace before ':'
Line 194:26: E203 whitespace before ':'
Line 268:26: E203 whitespace before ':'
Line 307:26: E203 whitespace before ':'

Line 354:26: E203 whitespace before ':'
Line 375:26: E203 whitespace before ':'

Comment last updated at 2020-01-09 12:50:19 UTC

Prepare for 4.15 release
@bashtage bashtage force-pushed the add-more-r2 branch 2 times, most recently from 5713822 to c57d1dd Compare January 9, 2020 12:47
Run black and isort to improve appearance
@bashtage bashtage merged commit 0ff07f5 into master Jan 9, 2020
@bashtage bashtage deleted the add-more-r2 branch January 9, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants