Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Docker Buildx Action Version #374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Consistent Docker Buildx Action Version #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Consistent Docker Buildx Action Version 
Changed the Docker Buildx action version in the nethermind job to v4 to match the others AND Ensured consistent indentation for better readability.

These changes should improve the workflow's consistency and clarity
  • Loading branch information
@Mukzid
Mukzid authored Dec 30, 2024
commit 4f7b83ea76f82cfd5f2742fe8aa58cb6e6acb089
5 changes: 3 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
file: geth/Dockerfile
push: false
platforms: ${{ matrix.arch }}

reth:
runs-on: ubuntu-latest
strategy:
Expand All @@ -47,6 +48,7 @@ jobs:
build-args: |
FEATURES=${{ matrix.features }}
platforms: ${{ matrix.arch }}

nethermind:
runs-on: ubuntu-latest
strategy:
Expand All @@ -60,10 +62,9 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Build the Docker image
uses: docker/build-push-action@v6
uses: docker/build-push-action@v4
with:
context: .
file: nethermind/Dockerfile
push: false
platforms: ${{ matrix.arch }}