Repository navigation
Conversation
Signed-off-by: Christian Dupuis <cd@docker.com> Co-authored-by: sbx docker/cdupuis/ab75af7b <sbx-ab75af7b@users.noreply.docker.com> Signed-off-by: Christian Dupuis <cd@docker.com> Sandbox-Id: spiffe://sbx.docker.com/org/57b45934-74c0-11e4-bea4-0242ac11001b/user/1580b874-0d59-41d8-bd81-82a10abc4100/sandbox/ab75af7b-5fa6-4709-9a90-93a6e885f932 Sandbox-Kit: sha256:856c306eb2ccdff13c9439fd2d560b217b17800f49f0ab24046f4637d3528623
Signed-off-by: Christian Dupuis <cd@docker.com> Sandbox-Id: spiffe://sbx.docker.com/org/57b45934-74c0-11e4-bea4-0242ac11001b/user/1580b874-0d59-41d8-bd81-82a10abc4100/sandbox/ab75af7b-5fa6-4709-9a90-93a6e885f932 Sandbox-Kit: sha256:856c306eb2ccdff13c9439fd2d560b217b17800f49f0ab24046f4637d3528623 Co-authored-by: sbx docker/cdupuis/ab75af7b <sbx-ab75af7b@users.noreply.docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep
watch-prfrom reporting READY before a pushed head's checks have appeared. GitHub can briefly report an UNKNOWN merge state with a successful rollup containing only DCO or a skipped hook. The watcher currently treats that as readiness.What changed
Scope
Tradeoffs
Polling resumes when GitHub supplies the missing evidence. No fixed settling delay or fabricated pending check is needed.
Blast Radius
Consumers of watcher JSON can now receive
github-pendingas a wait or timeout reason andci-github-pendingin status rows. Known conflicts, review blockers, failed checks, and completed PRs retain their existing decisions.Verification
bun test watch-pr check-plan.test.tspasses all 74 tests, including timeout, queue, blocker precedence, status rendering, and pending-rollup coverage.bun run typecheckandgit diff --checkpass.