docs: customize contributing guide#77
Merged
heitorlessa merged 9 commits intoaws-powertools:developfrom Jun 14, 2020
Merged
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Codecov Report
@@ Coverage Diff @@
## develop #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 516 516
Branches 49 49
=========================================
Hits 516 516 Continue to review full report at Codecov.
|
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Contributor
Author
|
I didn't add a CodeTour as initially planed since there will be deletion, and CodeTour needs to be pinned to a tag - I'll wait until GA. |
nmoutschen
reviewed
Jun 13, 2020
Contributor
Author
|
I removed because I created a bug report template issue that asks for more
details - I’m fine putting this back to Contributing if you think is
helpful.
Re: PR, good point - I’ll pick one and update it
…On Sat, 13 Jun 2020 at 09:48, Nicolas Moutschen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#77 (comment)>
:
>
When filing an issue, please check existing open, or recently closed, issues to make sure somebody else hasn't already
-reported the issue. Please try to include as much information as you can. Details like these are incredibly useful:
-
-* A reproducible test case or series of steps
Why remove this? I think this is rather helpful for us to reproduce the
issue.
------------------------------
In CONTRIBUTING.md
<#77 (comment)>
:
> 4. Commit to your fork using clear commit messages.
-5. Send us a pull request, answering any default questions in the pull request interface.
+5. Send us a pull request with a [conventional semantic title](https://github.com/awslabs/aws-lambda-powertools-python/pulls?q=is%3Apr+is%3Aclosed), and answering any default questions in the pull request interface.
Should we have a link to what is a conventional semantic title? This links
to closed PRs, which is descriptive rather than prescriptive.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#77 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBGFUYXDFOQQFSSOEGDRWM4OPANCNFSM4N4EY6QA>
.
|
Contributor
I checked the bug report template and looks good to me there, I'm fine keeping the steps out of CONTRIBUTING.md. |
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 14, 2020
* develop: docs: customize contributing guide (#77) chore: move blockquotes as hidden comments
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 17, 2020
* docs: clean up contributing guide Signed-off-by: heitorlessa <lessa@amazon.co.uk> * docs: add local documentation section Signed-off-by: heitorlessa <lessa@amazon.co.uk> * feat: experiment with Gitpod pre-build env Signed-off-by: heitorlessa <lessa@amazon.co.uk> * fix: unnecessary exc_info in example exception * docs: add conventions we use across the project Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore: remove gitpod due to poetry issue * chore: develop branch in bold Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore: add link to RFC issue, fix typo Signed-off-by: heitorlessa <lessa@amazon.co.uk> * chore: address Nicolas feedback on PR link Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 17, 2020
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits) feat: add metrics metadata (#81) chore: cleanup tests (#79) chore: remove deprecated code before GA (#78) docs: customize contributing guide (#77) chore: move blockquotes as hidden comments chore: update CHANGELOG chore: bump version to 0.11.0 (#76) chore: version bump 0.10.1 fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) docs: fix contrast on highlighted code text (#73) feat: improve error handling for log_metrics decorator (#71) chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs feat: add high level imports (#70) fix: correct env var name for publish to pypi test (#69) chore: version bump (#68) feat: add capture_cold_start_metric for log_metrics (#67) chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66) feat: automate publishing to pypi (#58) feat: add pre-commit hooks (#64) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #33
Description of changes:
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.