Skip to content

docs: customize contributing guide #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heitorlessa merged 9 commits into from
Jun 14, 2020
Merged

docs: customize contributing guide #77

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8852f0
docs: clean up contributing guide
heitorlessa Jun 12, 2020
2c6f135
docs: add local documentation section
heitorlessa Jun 12, 2020
b69cb59
feat: experiment with Gitpod pre-build env
heitorlessa Jun 12, 2020
1f43f33
fix: unnecessary exc_info in example exception
heitorlessa Jun 12, 2020
ea072ad
docs: add conventions we use across the project
heitorlessa Jun 12, 2020
123515d
chore: remove gitpod due to poetry issue
heitorlessa Jun 12, 2020
2fd564e
chore: develop branch in bold
heitorlessa Jun 12, 2020
09dfe26
chore: add link to RFC issue, fix typo
heitorlessa Jun 12, 2020
4132ccd
chore: address Nicolas feedback on PR link
heitorlessa Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: unnecessary exc_info in example exception
  • Loading branch information
@heitorlessa
heitorlessa committed Jun 12, 2020
commit 1f43f33ff0aec0407ae2c5b08a2ec350fcaf51b2
2 changes: 1 addition & 1 deletion example/hello_world/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def lambda_handler(event, context):
metrics.add_metric(name="SuccessfulLocations", unit="Count", value=1)
except requests.RequestException as e:
# Send some context about this error to Lambda Logs
logger.exception(e, exc_info=True)
logger.exception(e)
raise

with single_metric(name="UniqueMetricDimension", unit="Seconds", value=1) as metric:
Expand Down