test(s2n-quic-dc): use bach for request/response tests#2564
Merged
Conversation
WesleyRosenblum
approved these changes
Mar 25, 2025
dougch
pushed a commit
that referenced
this pull request
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change pulls in the latest bach version (0.0.12) to enable the stream tests to use simulated testing in addition to the tokio ones.
Call-outs:
I had to update the
s2n-quic-platformintegration a bit to match the new bach API. There were also some changes I made inbacharound task scheduling in order to be able to catch task leaks (tasks without a cloned waker somewhere) that had some effects on our stat snapshots. The functionality is the same though.Testing:
I ran the new
udp_sim::fuzz_testovernight and didn't run into any issues with panics, hangs, or leaks.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.