Repository navigation
Conversation
7 of 13 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 changed the value of
io.DEFAULT_BUFFER_SIZE, which breaks the testtest_base64io_decode_readlines. This pull request changes the test and parameterized test case values to account for this change. This change is backwards compatible, and the test will still pass on older versions of Python that use the original value ofio.DEFAULT_BUFFER_SIZE.The 3rd and 4th test cases assumed that 102400 bytes was more data than could be read in a one or two
Base64io.readcalls (respectively), which is no longer true due to the increasedio.DEFAULT_BUFFER_SIZE. Increasingsource_plaintextto be sized based on the value ofio.DEFAULT_BUFFER_SIZEfixes this by ensuring there will always be at least one extra byte that can't be read in two read calls.I'm aware that this repository doesn't advertise Python 3.14 support, but the code passed all the unit tests and basic smoke tests I threw at it. Since this doesn't break anything on earlier Python versions, I hope you will accept it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.