chore: Swap implementation of aspectj-maven-plugin to support Java 17#1172
Merged
jeromevdl merged 4 commits intoaws-powertools:masterfrom Jun 5, 2023
mriccia:issue-1156
Merged
chore: Swap implementation of aspectj-maven-plugin to support Java 17#1172jeromevdl merged 4 commits intoaws-powertools:masterfrom mriccia:issue-1156
aspectj-maven-plugin to support Java 17#1172jeromevdl merged 4 commits intoaws-powertools:masterfrom
mriccia:issue-1156
Conversation
2 tasks
jeromevdl
reviewed
Jun 2, 2023
Contributor
jeromevdl
left a comment
There was a problem hiding this comment.
Despite the use of a "non-official" maven plugin, I think it's ok. As the official one is not maintained anymore, we need to move on.
@mriccia did you try deploying the function with the different scenarios (java17 with mvn/gradle)
@msailes wdyt?
I also think we should update the e2e tests to add one with Java 17 now.
Contributor
|
I have no problem with using a different project which is maintained. I think this is the right thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: #1156
Description of changes:
According to mojohaus/aspectj-maven-plugin#154 this plugin should be swapped with dev-aspectj plugin, which works with Java 17 project.
This PR updates the repo, examples and docs to use the new plugin.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.