maintenance: send coverage (jacoco) to codecov

[jeromevdl]

Issue #, if available: #1080

Description of changes:

• removed cobertura as we have also jacoco
• merge results in parent target folder

Checklist

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

• Migration process documented
• Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@b062a76). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1094   +/-   ##
=========================================
  Coverage          ?   71.83%           
  Complexity        ?      523           
=========================================
  Files             ?       68           
  Lines             ?     2166           
  Branches          ?      230           
=========================================
  Hits              ?     1556           
  Misses            ?      503           
  Partials          ?      107           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jeromevdl]

It works: https://app.codecov.io/github/awslabs/aws-lambda-powertools-java/tree/unittest_coverage_report

[scottgerring]

It's not clear to me what the previous version of this was doing ..... shouldn't matrix.java-version have always been null? :|

[jeromevdl]

I think so. Not sure the environment variable is even used actually...

[scottgerring]

Only related to change insofar as matrix.java-version was also not defined in the matrix context. In this case I think matrix.os has been taken from the matrix examples but is being misused here because it is never set.

I suggest removing this. I can see no usages of OS within the codebase, and this is actively confusing. Adding the filter on the matrix to ensure codecov runs once adds to this - if we actually had a 2D matrix with OS as well, which this implies, the filter would not be enough.

[jeromevdl]

yep, will try to remove the os to see if it still works.

[scottgerring]

A couple comments inline that are tenuously related about the way we're using the build matrix

[jeromevdl]

@scottgerring anything else?

[scottgerring]

LGTM!