Ensure Docker logging facilities can see gunicorn errors#3389
Merged
Conversation
…ockers log stream Signed-off-by: Adrian Edwards <adredwar@redhat.com>
bdb08e1 to
c642462
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, if gunicorn crashes due to an error, the docker logs will only show the attempt to start the gunicorn (frontend) web server processes followed by their immediate shutdown. The cause is only findable by looking in the configured log directory and reading the log files.
This PR uses the environment variable for docker deployments to change the gunicorn config to redirect errors to stdout so they get picked up by docker
Notes for Reviewers
So uuh, I fixed the issue that was causing gunicorn to crash before realizing i should use it to test this, so while im not certain it works, it should be a pretty basic change and lines up with the gunicorn docs for this errorlog setting
Signed commits