facade: refactor facade_phase to return the group itself so that celery can properly convert things into a chord#3273
Merged
sgoggins merged 1 commit intoaugurlabs:mainfrom Sep 16, 2025
Conversation
Ulincsys
reviewed
Sep 15, 2025
|
|
||
| logger.info(f"Facade sequence: {facade_sequence}") | ||
| return chain(*facade_sequence) No newline at end of file | ||
| return facade_sequence[0] No newline at end of file |
Collaborator
There was a problem hiding this comment.
Is there a particular reason to keep the list if we are just going to peek the first item from it on return?
Collaborator
Author
There was a problem hiding this comment.
i only did this to preserve the log statement. i guess if the print statement can handle the list of objects just fine, it should be fine to just throw the object at it.
Collaborator
Author
There was a problem hiding this comment.
thanks for calling me out on my addition of tech debt lol - this probably isnt necessary, i think i was just like "eh whatever it works" when i wrote it and forgot to revisit
Collaborator
Author
|
oh fun, i guess one of my rebases or amends must have stripped out the DCO... |
This was
linked to
issues
Sep 16, 2025
…roperly convert things into a chord Signed-off-by: Adrian Edwards <adredwar@redhat.com>
ca9b4e0 to
83d0db1
Compare
Ulincsys
approved these changes
Sep 16, 2025
sgoggins
approved these changes
Sep 16, 2025
Collaborator
sgoggins
left a comment
There was a problem hiding this comment.
This is looking useful!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While I haven't been certain that I can see the facade recollection issue locally, this change allowed me to successfully find
facade_task_success_utilvia a flower task search in my local instance, meaning the tasks that were not running are now running again,The thing that helped me get through this issue was this analysis from GPT5:
Notes for Reviewers
In doing this refactor, I didnt see any other uses of
facade_phasebesides inbuild_facade_repo_collect_request, so it doesnt seem like the specific return type here is being super heavily relied on (although maybe thats due to an unwritten convention as noted in #3272)Signed commits