Don't log GitHub and Gitlab credentials#3132
Merged
sgoggins merged 1 commit intoaugurlabs:devfrom Apr 23, 2025
Merged
Conversation
Remove environment variable values from log messages to prevent sensitive information from being exposed. This change improves security by not displaying API keys and usernames in the console output. Signed-off-by: John Strunk <jstrunk@redhat.com>
sgoggins
approved these changes
Apr 23, 2025
sgoggins
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove environment variable values from log messages to prevent sensitive information from being exposed. This change improves security by not displaying API keys and usernames in the console output.
This is particularly an issue in containerized environments (e.g., docker/kube/openshift) where the logs are preserved indefinitely and potentially shipped off-cluster.
This PR fixes #
Notes for Reviewers
Signed commits