-
Notifications
You must be signed in to change notification settings - Fork 19
Run and add rustfmt #49
Conversation
|
Let's wait for #46 before merging. Rebasing and reformatting this is trivial. |
epage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once cache issues are resolved.
|
@killercup you can merge this PR, I will rebase mine ( #46 ) after that. I can also add coveralls to have more details about code coverage as well. here's an example of how it works with travis: https://github.com/Freyskeyd/Rundeck/blob/master/.travis.yml |
This better work, or I'll just remove the condition!
|
Oh, I didn't realize the binaries were cached as well. Fine. Let's be clever. @Freyskeyd, I removed coveralls in 9d81ed8 because the data wasn't very good. Maybe that changed? |
|
@killercup Dunno if change, I didn't get any trouble. |
|
You are welcome to add it again with the same tokens as in the linked commit and see if it's helpful :) But in the meantime: bors r+ |
Build succeeded |
No description provided.