Conversation
Signed-off-by: Simon MacDonald <simon.macdonald@gmail.com>
ryanbethel
approved these changes
Mar 2, 2026
Contributor
ryanbethel
left a comment
There was a problem hiding this comment.
Looks good. Left a comment as a note for future us.
| let regions = results | ||
| .map(({ Value }) => Value) | ||
| .filter(r => !r.startsWith('cn-') && !r.startsWith('us-gov-')) | ||
| // TODO Remove next line when ME AWS regions are back up |
Contributor
There was a problem hiding this comment.
I think this is good for now. I will mention so we will hopefully remember that if we publish and a layer is skipped of a region (either because the publish workflow fails intermittently or in this case we are explicitly skipping) then it can mess up the auto versioning of the layers. Like if we just publish another update we may end up with one region that is named <stuff>:3 and the rest are <stuff>:4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ME aws regions are currently down so skip publishing to them for now.