Make it possible to record screen on Android P emulators#345
Merged
mykola-mokhnach merged 5 commits intoappium:masterfrom Mar 22, 2018
Merged
Make it possible to record screen on Android P emulators#345mykola-mokhnach merged 5 commits intoappium:masterfrom
mykola-mokhnach merged 5 commits intoappium:masterfrom
Conversation
Contributor
Author
|
@KazuCocoa FYI |
4 tasks
imurchie
approved these changes
Mar 22, 2018
lib/commands/recordscreen.js
Outdated
| commands.stopRecordingScreen = async function (options = {}) { | ||
| const {remotePath, user, pass, method} = options; | ||
|
|
||
| const apiLevel = await this.adb.getApiLevel(); |
Contributor
There was a problem hiding this comment.
This validity check could be extracted out, since it is repeated twice (and in the future might change in both places, as different versions of things support different things).
added 2 commits
March 22, 2018 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like Google has finally fixed compatibility issues since Android P and from now on one can record screen on emulator the same way he does it on real devices.