ZOOKEEPER-4886: Fix observer with small myid can't join SASL quorum #2211
+118
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zichen-gan for taking care of this. Could you please create a jira ticket first? |
anmolnar
reviewed
Nov 5, 2024
|
sure, I create a jira ticket: https://issues.apache.org/jira/browse/ZOOKEEPER-4886 @anmolnar yes, small myid observer can't join sasl quorum. |
|
Because zk always takes the initiative to connect myid with a larger myid.And startConnection() only authenticate when peer is voting, so observer can't join quorum. |
0e68d1c to
dc9fe0f
Compare
kezhuw
approved these changes
Dec 21, 2024
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
Outdated
Show resolved
Hide resolved
...per-server/src/test/java/org/apache/zookeeper/server/quorum/auth/QuorumAuthObserverTest.java
Outdated
Show resolved
Hide resolved
...per-server/src/test/java/org/apache/zookeeper/server/quorum/auth/QuorumAuthObserverTest.java
Outdated
Show resolved
Hide resolved
dc9fe0f to
84a7ec9
Compare
…rum/auth/QuorumAuthObserverTest.java
kezhuw
reviewed
Jan 23, 2025
There was a problem hiding this comment.
The test failed in both github action and jenkins due to @Timeout(value = 30). I planed to drop it as the test has watcher.waitForConnected(ClientBase.CONNECTION_TIMEOUT) already.
...per-server/src/test/java/org/apache/zookeeper/server/quorum/auth/QuorumAuthObserverTest.java
Outdated
Show resolved
Hide resolved
...per-server/src/test/java/org/apache/zookeeper/server/quorum/auth/QuorumAuthObserverTest.java
Outdated
Show resolved
Hide resolved
…rum/auth/QuorumAuthObserverTest.java
…rum/auth/QuorumAuthObserverTest.java
kezhuw
reviewed
Jan 23, 2025
...per-server/src/test/java/org/apache/zookeeper/server/quorum/auth/QuorumAuthObserverTest.java
Outdated
Show resolved
Hide resolved
…rum/auth/QuorumAuthObserverTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZK BUG Like QuorumAuthObserverTest#testSmallObserverJoinSASLQuorum
When SASL Quorum like:
server.11=localhost:11223:11224:participant
server.21=localhost:11226:11227:participant
server.1=localhost:11229:11230:observer
The server.1 can't join quorum.