feat(service/s3): support crc64nvme algorithm #6815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Member
|
This crate seems pretty great |
Xuanwo
reviewed
Nov 24, 2025
core/Cargo.toml
Outdated
| "dispatcher", | ||
| ] } | ||
| # for services-s3 | ||
| crc32c = { version = "0.6.6", optional = true } |
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Member
|
Do we still want this after checksum has been implemented? I can imagine that we will deprecate all settings at the S3 level. |
# Conflicts: # core/Cargo.lock # core/Cargo.toml # core/services/s3/src/backend.rs # core/services/s3/src/config.rs
Member
Author
Makes sense. Should we move the overall development of checksum to the dedicated layer proposed in #6817 ? If so I can close this PR and continue on the layer |
Member
Yes and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Support
crc64nvmeagain, withcrc-fast. It's the successor ofcrc64fast-nvme. Related discussion awesomized/crc64fast-nvme#13 (comment)What changes are included in this PR?
Support
crc64nvmechecksum algorithm for s3Are there any user-facing changes?
Yes, a new feature