feat(bindings/python): Enable ftp/hdfs_native/sftp for python #6745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chitralverma
commented
Oct 28, 2025
Contributor
Author
There was a problem hiding this comment.
these big diffs are because previously no sorting was in place.
chitralverma
commented
Oct 28, 2025
Comment on lines
+52
to
+53
| 'default', | ||
| 'services-aliyun-drive', |
Contributor
Author
There was a problem hiding this comment.
sorted and cleaned this area up. moved comments in 1 place below.
re enabled the listed services
chitralverma
commented
Oct 28, 2025
| services-alluxio = ["opendal/services-alluxio"] | ||
| services-azfile = ["opendal/services-azfile"] | ||
| services-b2 = ["opendal/services-b2"] | ||
| services-cacache = ["opendal/services-cacache"] |
chitralverma
commented
Oct 28, 2025
| services-redb = ["opendal/services-redb"] | ||
| services-redis = ["opendal/services-redis"] | ||
| services-rocksdb = ["opendal/services-rocksdb"] | ||
| services-redis = ["opendal/services-redis", "opendal/services-redis-native-tls"] |
Contributor
Author
There was a problem hiding this comment.
included services-redis-native-tls
chitralverma
commented
Oct 28, 2025
Comment on lines
172
to
173
| # we build cp311-abi3 and cp310 wheels now, move this to pyo3 after we drop cp310 | ||
| abi3 = ["pyo3/abi3-py311"] |
Contributor
Author
There was a problem hiding this comment.
did not remove the comment over abi, but this needs to be carefully done or there will be a conflict with stubgen.
Xuanwo
approved these changes
Oct 28, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @chitralverma for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
This is the last one for all refactoring of python bindings in order to get things up to date with core.
What changes are included in this PR?
services-redis-native-tlsfeature along withservices-rediswhich was missingAre there any user-facing changes?
No changes to existing APIs but this enables new services in py bindings.