feat: implement content-md5 for s3 #6508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Xuanwo
reviewed
Aug 15, 2025
core/src/services/s3/config.rs
Outdated
| /// When enabled, OpenDAL will calculate and include the Content-MD5 header | ||
| /// for PUT operations (single uploads, multipart parts, and append operations). | ||
| /// This header provides an additional layer of data integrity verification. | ||
| pub enable_content_md5: bool, |
Member
There was a problem hiding this comment.
I don't think it's the correct approch to implement data integrity verification.
Maybe we can take a look over #5549
Member
There was a problem hiding this comment.
How about implementing content_md5 as one of checksum_algorithm?
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Xuanwo
reviewed
Oct 30, 2025
core/src/services/s3/core.rs
Outdated
| .for_each(|b| crc = crc32c::crc32c_append(crc, &b)); | ||
| Some(BASE64_STANDARD.encode(crc.to_be_bytes())) | ||
| } | ||
| Some(ChecksumAlgorithm::Md5) => Some(format_content_md5(body.to_bytes().as_ref())), |
Member
There was a problem hiding this comment.
Do we have a better way to handle this, like calculating in a stream instead of calling body.to_bytes() first? Our users might send data up to 5GiB in a single request.
Member
Author
There was a problem hiding this comment.
👍 made a non-copy version format_content_md5_iter that works on iterator
Signed-off-by: Ruihang Xia <[email protected]>
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5550.
Rationale for this change
Content-MD5is required in some S3-compatible servicesWhat changes are included in this PR?
Add
Content-MD5support for S3 backend.Test with
oliAre there any user-facing changes?
New option for S3 backend