-
Notifications
You must be signed in to change notification settings - Fork 707
feat(bindings/cpp): enable user-configurable features for storage services #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bindings/cpp): enable user-configurable features for storage services #6503
Conversation
Remove hardcoded service dependencies to enable user-configurable features. Only keep 'blocking' feature as it's required for C++ bindings. Related to apache#6250
|
refer to here
|
|
opendal/.github/actions/test_behavior_binding_cpp/action.yaml Lines 47 to 53 in 542df66
Maybe you need to add the feature config here. |
can't understand... |
|
monoiofs |
Alluxio doesn't support file overwrite without explicit overwrite option. Related to apache#6250
Alluxio doesn't support file overwrite without explicit overwrite option. Related to apache#6250
Alluxio doesn't support file overwrite without explicit overwrite option. Related to apache#6250
Alluxio doesn't support file overwrite without explicit overwrite option. Related to apache#6250
Alluxio has different list behavior that includes unexpected paths. Related to apache#6250
Alluxio has different list behavior that includes unexpected paths. Related to apache#6250
Alluxio has different list behavior that includes unexpected paths. Related to apache#6250
Alluxio has different list behavior that includes unexpected paths. Related to apache#6250
Alluxio has different list behavior that includes unexpected paths. Related to apache#6250
Alluxio has different list behavior that includes unexpected paths. Related to apache#6250
efb120e to
6129ffd
Compare
|
seems only memory leak now. |
Thank you for the work, I think we can disable cpp test on those two services for now. |
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thank you for your work!
…ation test Related to apache#6250
…gFile test Related to apache#6250
…ior test Related to apache#6250
…rFile test Related to apache#6250
dce280e to
ae941db
Compare
Which issue does this PR close?
Closes #6250.
Rationale for this change
Currently, the C++ binding hardcodes all storage service features in
Cargo.toml, which means:This PR implements user-configurable features similar to the C binding (#4313), allowing users to specify only the storage services they need at build time.
What changes are included in this PR?
bindings/cpp/Cargo.toml: Removed hardcoded service dependencies, keeping only the essentialblockingfeaturebindings/cpp/CMakeLists.txt:FEATUREScache variable for user configurationOPENDAL_ENABLE_ASYNCoptionAre there any user-facing changes?
FEATURES- allows users to specify which OpenDAL storage services to includeOPENDAL_ENABLE_ASYNCcontinues to work unchanged-DFEATURES="service1,service2"to their cmake commands to include storage services