-
Notifications
You must be signed in to change notification settings - Fork 707
ci: refactor nodejs ci workflow #6491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4dfb3c4 to
af531a0
Compare
|
cc @Xuanwo Testing with publish dry run works as expected: https://github.com/apache/opendal/actions/runs/16825258046/job/47660615280?pr=6491 Two workflow_dispatch events have been added:
|
|
So cool! |
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others look good to me, thank you for working on this!
| - "core/**" | ||
| - ".github/workflows/ci_bindings_nodejs.yml" | ||
| workflow_dispatch: | ||
| inputs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we have two workflows (like other langauge): ci_bindings_nodejs.yml and release_nodejs, can we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
| "files": [ | ||
| "opendal.linux-arm64-gnu.node" | ||
| ], | ||
| "description": "Apache OpenDAL: Access data freely", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note our vision has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed: "Apache OpenDAL: One Layer, All Storage."
|
cc @Xuanwo Testing with publish dry run works as expected. release_nodejs.yml |
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice! Thank you @kingsword09.
Which issue does this PR close?
Closes #6489.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?