fix(services/oss): unnecessary header 'content-type' are included in the get_object request #6455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the get_object request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The current implementation incorrectly includes a 'Content-Type' header in get_object requests to OSS. According to the official SDK documentation and specifications, this header should not be included for get_object operations. This unnecessary header cause the pre-signed get object request URL can't directly usable in browsers.
What changes are included in this PR?
Removed the 'Content-Type' header from the request builder for get_object operations in the OSS service implementation. This aligns the behavior with the official OSS SDK specifications.
Are there any user-facing changes?
Yes, but they are internal improvements: