feat(bindings/cpp): enhance Metadata API with comprehensive feature a… #6445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lignment - Align C++ Metadata struct with Rust implementation for full feature parity - Add missing fields: content_encoding, version, is_current, is_deleted - Implement comprehensive accessor methods with detailed documentation - Add extensive BDD-style test suite with 20 test cases covering: * File and directory metadata behavior * HTTP headers and optional fields handling * Versioning information and deletion status * API consistency and object lifecycle * Timestamp behavior and edge cases * Error handling and robustness testing - Update FFI layer with OptionalBool type for proper type mapping - Enhance type conversion between Rust and C++ representations - Maintain backward compatibility while extending functionality Signed-off-by: Jack Drogon <[email protected]>
Contributor
Author
|
@Xuanwo @deadlinefen need a review |
…etadata - Replace constructor initialization list with in-class member initializers - Use brace initialization syntax for default values - Mark constructor and destructor as default - Improve code consistency with modern C++ practices Signed-off-by: Jack Drogon <[email protected]>
Xuanwo
approved these changes
Jul 29, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @JackDrogon for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Metadata API with comprehensive feature alignment