Skip to content

Conversation

@koushiro
Copy link
Member

@koushiro koushiro commented Jun 8, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Replace moka::sync::Cache with moka::future::Cache

Are there any user-facing changes?

@koushiro koushiro requested a review from Xuanwo as a code owner June 8, 2025 13:39
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Jun 8, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 8, 2025
@Xuanwo Xuanwo changed the title refactor(services/moka): replace sync::Cache with future::Cache refactor(services/moka)!: replace sync::Cache with future::Cache Jun 8, 2025
@Xuanwo Xuanwo merged commit fb865f2 into main Jun 8, 2025
93 checks passed
@Xuanwo Xuanwo deleted the change-moka-cache-type branch June 8, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants