Skip to content

Conversation

@asukaminato0721
Copy link
Contributor

Which issue does this PR close?

part of #2756.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@asukaminato0721 asukaminato0721 changed the title add more api for caml add more api for ocaml May 30, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review May 31, 2025 08:34
@asukaminato0721 asukaminato0721 requested a review from Xuanwo as a code owner May 31, 2025 08:34
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 31, 2025
@asukaminato0721 asukaminato0721 changed the title add more api for ocaml feat(bindings/ocaml): add more blocking api for ocaml May 31, 2025
@asukaminato0721
Copy link
Contributor Author

here are the publish steps.

  1. Install required tools:
opam install dune-release
  1. Set up opam-repository fork:
# Fork https://github.com/ocaml/opam-repository on GitHub
git clone https://github.com/YOUR_USERNAME/opam-repository.git

Publishing Process

  1. Prepare the release:
cd bindings/ocaml
./release.sh 0.48.0  # Replace with your version
  1. Test locally:
# Test installation from the local directory
opam install . --deps-only
opam install .

# Test that it works
ocaml -I $(opam var lib)/opendal -c "open Opendal.Operator"
  1. Submit to opam-repository:
dune-release publish distrib --verbose

@asukaminato0721
Copy link
Contributor Author

cc @Ranxy

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asukaminato0721 for your work on this. Most of the API changes for OCaml look good to me. My only concern is that it would be better to move the release part into a separate PR.

@@ -0,0 +1,43 @@
# Changelog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I love this.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@Xuanwo Xuanwo merged commit b04da7c into apache:main Aug 3, 2025
34 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 3, 2025
@asukaminato0721 asukaminato0721 deleted the ocaml-api branch August 3, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bindings/ocaml lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants