Skip to content

Conversation

@asukaminato0721
Copy link
Contributor

Which issue does this PR close?

Closes #1251.

Rationale for this change

What changes are included in this PR?

a new RFC

Are there any user-facing changes?

@asukaminato0721 asukaminato0721 changed the title RFC-5871: Read Returns Metadata RFC-6209: glob api May 21, 2025
@asukaminato0721 asukaminato0721 changed the title RFC-6209: glob api RFC-6209: Glob Api May 21, 2025
@asukaminato0721 asukaminato0721 changed the title RFC-6209: Glob Api RFC-6209: Glob Support May 21, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review May 21, 2025 09:00
@asukaminato0721 asukaminato0721 requested a review from Xuanwo as a code owner May 21, 2025 09:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 21, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this RFC was generated by AI. (Please let me know if I'm mistaken and I owe you an apology.)

How about reviewing OpenDAL's existing API and refining the RFC accordingly?

@Xuanwo
Copy link
Member

Xuanwo commented May 22, 2025

Given that RFC-6189 has been approved, we will soon remove all native blocking APIs. Therefore, we no longer need to consider blocking APIs in our design.

@asukaminato0721 asukaminato0721 requested a review from Xuanwo May 22, 2025 12:43
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great RFC! Thank you @asukaminato0721 for working on this.

We are ready to merge this PR after conflicts been resolved.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 23, 2025
@asukaminato0721 asukaminato0721 requested a review from Xuanwo May 24, 2025 04:38
@Xuanwo Xuanwo merged commit 29f74a9 into apache:main May 24, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(core): support for matching file paths against Unix shell style patterns (glob).

3 participants