Skip to content

fix(bindings/go): Reader returns io.EOF at the end of file #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 1 commit into from
May 6, 2025
Merged

fix(bindings/go): Reader returns io.EOF at the end of file #6150

Xuanwo merged 1 commit into from
May 6, 2025

Conversation

@yuchanns
Copy link
Member

@yuchanns yuchanns commented May 6, 2025

Close #6148

@yuchanns yuchanns requested a review from Xuanwo as a code owner May 6, 2025 04:23
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels May 6, 2025
@yuchanns yuchanns marked this pull request as draft May 6, 2025 04:30
@yuchanns yuchanns force-pushed the fix-go-binding-eof branch 3 times, most recently from e9b0d60 to a5fa98a Compare May 6, 2025 04:44
@yuchanns
Copy link
Member Author

yuchanns commented May 6, 2025

Error: 2025/05/06 04:47:08 could not read secret 'op://services/azblob/container': could not retrieve item 'services/azblob': Get "***/v1/vaults?filter=title+eq+%22services%22": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-05-06T04:47:08Z is after 2025-05-06T03:09:13Z
Error: The process '/usr/bin/sh' failed with exit code 1

I don't think it's any of Go binding's business. @Xuanwo

@yuchanns yuchanns marked this pull request as ready for review May 6, 2025 04:50
@Xuanwo
Copy link
Member

Xuanwo commented May 6, 2025

I don't think it's any of Go binding's business. @Xuanwo

Sorry for this, should be fixed now.

@yuchanns yuchanns force-pushed the fix-go-binding-eof branch from a5fa98a to 2b3e0cc Compare May 6, 2025 06:19
@yuchanns
Copy link
Member Author

yuchanns commented May 6, 2025

It is ready now.

Xuanwo
Xuanwo approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you @yuchanns

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 6, 2025
@Xuanwo Xuanwo merged commit 33172c1 into main May 6, 2025
71 checks passed
@Xuanwo Xuanwo deleted the fix-go-binding-eof branch May 6, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: (bindings/go): Reader does not return io.EOF at end of file, causing non-terminating loop.

2 participants

@yuchanns @Xuanwo