Skip to content

Conversation

@erickguan
Copy link
Member

Which issue does this PR close?

Closes #5774.

Are there any user-facing changes?

No

Inviting @jorgehermo9 for this one too if you have time!

@erickguan erickguan requested a review from Xuanwo as a code owner April 28, 2025 19:17
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Apr 28, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @erickguan for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2025
@Xuanwo
Copy link
Member

Xuanwo commented Apr 29, 2025

Hi @erickguan, since you’re now a committer, you can create branches directly on the upstream and create PRs from it so our CI can run with credentials for you.

@Xuanwo Xuanwo merged commit 2bdb635 into apache:main Apr 29, 2025
87 checks passed
@erickguan
Copy link
Member Author

@Xuanwo Thanks for the tips!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add http context in for all http based services

2 participants