feat(services/s3): Support request payer option #6070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninferrand
commented
Apr 20, 2025
antoninferrand
commented
Apr 20, 2025
ef5b68c to
23be0d7
Compare
antoninferrand
commented
Apr 20, 2025
Xuanwo
approved these changes
Apr 20, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Most changes look good to me, thank you @antoninferrand for this and thank you @jorgehermo9 for joining review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5694 .
Rationale for this change
See the issue.
What changes are included in this PR?
See the issue.
Are there any user-facing changes?
It exposes a new option in the builder.
What is missing
AWS returns
x-amz-request-charged:requesterwhen the request has been billed to the client.We don't surface it.