feat(services/aliyun_drive): Add operation in http context #6063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgehermo9
commented
Apr 20, 2025
| serde_json::from_reader(res.reader()).map_err(new_json_serialize_error)?; | ||
|
|
||
| let download_url = self.core.get_download_url(&file.file_id).await?; | ||
| // TODO: this request should be done in core.rs and not here |
Contributor
Author
There was a problem hiding this comment.
I left this TODO since I think we should refactor this and this request needs to be in core.rs. get_download_url should be renamed to something like download_file that both gets the download url & downloads it in the same function, right?
Should I refactor that in this PR? or leave the TODO?
This was referenced Apr 20, 2025
erickguan
approved these changes
Apr 26, 2025
Member
erickguan
left a comment
There was a problem hiding this comment.
Good catch. Good plan with the context too!
Xuanwo
approved these changes
Apr 27, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @jorgehermo9 for working on this and thank you @erickguan for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5774. I noticed that in #5880, there was one missing request without
extension. Note that #5880 included that extension in the functions undercore.rs, but there was this request that was sent inbackend.rs.