feat(bindings/python): Add start_after support for list #6054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Apr 20, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Others look good to me, thanks a lot for this!
| async def presign_stat( | ||
| self, path: PathBuf, expire_second: int | ||
| ) -> PresignedRequest: | ||
| async def scan( |
Member
There was a problem hiding this comment.
Scan should be replaced by list(recursive=True). We can add this for list first.
Contributor
Author
There was a problem hiding this comment.
So anything to do on this pr?
Contributor
|
do we need add test for it? |
lint ruff check --select I --fix . rm test
f143113 to
3145c67
Compare
1495bc6 to
7a07216
Compare
Contributor
Author
done |
Xuanwo
approved these changes
Apr 20, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @asukaminato0721 for building this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6042 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?