Skip to content

feat(binding/dart): hide init && change to init #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 5 commits into from
Mar 11, 2025
Merged

feat(binding/dart): hide init && change to init #5742

Xuanwo merged 5 commits into from
Mar 11, 2025

Conversation

@asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Mar 11, 2025 •
edited
Loading

Which issue does this PR close?

part of #5722 (comment) .

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

change the api name.

@asukaminato0721 asukaminato0721 changed the title hide init && change to init feat(binding/java): hide init && change to init Mar 11, 2025
@asukaminato0721 asukaminato0721 changed the title feat(binding/java): hide init && change to init feat(binding/dart): hide init && change to init Mar 11, 2025
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Mar 11, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review March 11, 2025 09:36
@asukaminato0721 asukaminato0721 requested a review from Xuanwo as a code owner March 11, 2025 09:36
@Xuanwo
Copy link
Member

Xuanwo commented Mar 11, 2025

Hi, partly closes will close the issue directly, and GitHub is not smart enough to recognize that it's partly closes and not just closes. So let's just use part of.

Xuanwo
Xuanwo reviewed Mar 11, 2025
View reviewed changes
@asukaminato0721 asukaminato0721 requested a review from Xuanwo March 11, 2025 11:22
Xuanwo
Xuanwo approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asukaminato0721 for working on this.

@Xuanwo Xuanwo merged commit 41b2f82 into apache:main Mar 11, 2025
32 checks passed
@asukaminato0721 asukaminato0721 deleted the dart-hide-init branch March 11, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asukaminato0721 @Xuanwo