feat(services/gcs): Implement multipart/related and use it with Gcs #5691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status of this PR:
With this PR applied, I am able to set metadata such as
content_encodingandcontent_typein write operations withGcs. I have tested it with the official Storage emulator provided byfirebase-tools.What's missing:
I haven't tested this with the actual GCS yetEDIT: Tested in our projectUnit tests forEDIT: There's now a simple unit testRelatedPartWhich issue does this PR close?
Closes #5624
TL;DR: Improves GCS API compliance
Rationale for this change
The rationale for the change is discussed in the issue.
What changes are included in this PR?
multipart/related(RelatedPart)RelatedPartingcs_insert_object_requestinstead ofFormDataPartAre there any user-facing changes?
None