Skip to content

Conversation

@tisonkun
Copy link
Member

AS IS

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from Xuanwo as a code owner February 13, 2025 08:09
@github-actions github-actions bot added the releases-note/build The PR modifies build related content or has a title that begins with "build" label Feb 13, 2025
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #5625 will degrade performances by 21.21%

Comparing otel-028 (b92e819) with main (69c8fab)

Summary

❌ 12 regressions
✅ 61 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
buffer 256 KiB * 32 chunk 125.3 ns 154.4 ns -18.88%
buffer 256 KiB * 4 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 32 chunk 125.3 ns 154.4 ns -18.88%
buffer 4.00 MiB * 4 chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1000k chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1000k truncate 216.7 ns 275 ns -21.21%
256 KiB * 100k chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 100k truncate 216.7 ns 275 ns -21.21%
256 KiB * 10k chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 10k truncate 216.7 ns 275 ns -21.21%
256 KiB * 1k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 1k truncate 216.7 ns 275 ns -21.21%

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tisonkun for working on this!

@Xuanwo Xuanwo merged commit 287ff3c into main Feb 13, 2025
280 of 281 checks passed
@Xuanwo Xuanwo deleted the otel-028 branch February 13, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/build The PR modifies build related content or has a title that begins with "build"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants