refactor: refactor all body.copy_to_bytes(body.remaining()) #5561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix to clippy warning Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Xuanwo <[email protected]>
Xuanwo
reviewed
Jan 17, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for this, most changes look good to me.
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
Xuanwo
approved these changes
Jan 17, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @yihong0618 for taking care of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix to clippy warning
and drop some unused import.
Which issue does this PR close?
Closes #. comments from #5554
Rationale for this change
comments from #5554
What changes are included in this PR?
body.copy_to_bytes(body.remaining()) -> body.to_bytes()
Are there any user-facing changes?