LIBCLOUD-760 malformed xml requests #610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected dd-ap 'host'
Member
|
/cc @erjohnso I assume you will merge this when rolling out a new 0.19.0 release, right? |
Contributor
|
Yes. From the thread on dev, we'll close that vote thread and @tonybaloney is planning on adding some basic tests. That can go in this PR too. |
…t XML tag of the requests matches the correct documented tag names (and caps)
Contributor
Author
|
@erjohnso these are the required tests to check the request bodies as well for typos. all done |
Contributor
|
Outstanding, thank you @tonybaloney! I'll get this merged in later tonight and start working on the revised 0.19.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 2 bugs raised by @EfrenRey where delete Nat rule, edit firewall rule are not containing the right capitalization of Rule in the XML request.