Add pyspark DataFusion integration test #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54a482b to
6709685
Compare
lewiszlw
reviewed
Dec 27, 2024
6709685 to
318ff77
Compare
lewiszlw
approved these changes
Dec 27, 2024
kevinjqliu
previously approved these changes
Jan 4, 2025
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Great to see an example using datafusion's TableProvider
sdd
reviewed
Jan 13, 2025
sdd
requested changes
Jan 13, 2025
Contributor
sdd
left a comment
There was a problem hiding this comment.
Looks good to me, once the Cargo.toml change is made. Thanks :-)
abfd516 to
b6e171e
Compare
This is so that both the datafusion integration and integration test crates can inherit the same version.
98cadea to
be35fb1
Compare
Contributor
Author
sdd
approved these changes
Jan 22, 2025
Contributor
|
It's a yes from me @gruuya - approved 🙂 |
Member
|
Thank you @gruuya for working on this, and thank you @Fokko, @kevinjqliu, @liurenjie1024 and @sdd for the review. Sorry for the late, let's move! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests propagation of all supported primitive types in an e2e manner.
Alternative to #825.