fix: expand arrow to iceberg schema to handle nanosecond timestamp #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Nov 27, 2024
Fokko
approved these changes
Nov 27, 2024
liurenjie1024
approved these changes
Nov 28, 2024
Contributor
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @jdockerty for adding this!
shaeqahmed
pushed a commit
to matanolabs/iceberg-rust
that referenced
this pull request
Dec 9, 2024
…pache#710) * fix: expand schema conversion data types for nanoseconds * fix: use ns timestamp variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #709
The changes here stopped the resulting panic that was shown in the linked issue.
Nanosecond precision can be written by
parquet-rsandiceberg-rusthas some support for this recently too.