-
Notifications
You must be signed in to change notification settings - Fork 395
feat(catalog): impl builder for SqlCatalog #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The implementation is complete and I'd like you to review it. 🙇 |
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @335g for this pr! Left some comments to resolve.
|
@liurenjie1024 Thanks for the review! I've addressed the comments you made. 🙇🏼 |
|
@liurenjie1024 May I ask a question?
impl SqlCatalogBuilder {
pub fn new(file_io: FileIO) -> Self {
...
}
}If possible, I'd like to remove |
|
Hi, @335g I'm not convinced that we should remove
It's |
|
Hi, @liurenjie1024 Thanks for the comment. I realized I didn't fully understand the previous comment. I've made some adjustments to the implementation - how does this look? |
|
Resolved conflict |
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @335g for this pr, generally LGTM! Just one minor point.
|
Oops, we need to resolve conflict first. |
|
Thanks @liurenjie1024 for review. The points you commented on have been addressed. |
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @335g for this pr!
Which issue does this PR close?
What changes are included in this PR?
SqlCatalogBuilderimplementation foriceberg::CatalogBuilder.SqlCatalogConfigtoSqlCatalogBuilder, we've simplified the process for creatingSqlCatalogobjects.Box<dyn BoxedCatalogBuilder>for theSqlCatalogvia theloadfunction (Implement catalog loader function. #1260)Are these changes tested?
Yes (only tested whether it could be made)