chore: upgrade roaring to 0.11 #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
approved these changes
Aug 4, 2025
Contributor
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @dentiny for this pr!
Yiyang-C
pushed a commit
to Yiyang-C/iceberg-rust
that referenced
this pull request
Aug 26, 2025
## What changes are included in this PR? This PR upgrades `roaring` dependency from 0.10 to 0.11. Motivation: - Latest roaring v0.11 includes all features described in spec, including `run container` which is only supported in v0.11 + See v0.11 release notes: https://github.com/RoaringBitmap/roaring-rs/releases + The missing feature blocks iceberg-rust to read deletion vector puffin blob written by other engines - I do notice iceberg-rust has configured dependabot and triggers on weekly basic, but doesn't seem to upgrade this particular crate for a while + The v0.11 was release 6 weeks ago, which I expect to upgrade with no human intervene I checked there's one version for `roaring`. Another change I made is to switch from `<major>.<minor>.<patch>` to `<major>.<minor>`; I do notice `cargo` is very good at figuring out a crate version which works for all or most dependency requirements. A precise version requirement is easy to lead to multiple versions for one single crate. ## Are these changes tested? No op change, CI should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
This PR upgrades
roaringdependency from 0.10 to 0.11.Motivation:
run containerwhich is only supported in v0.11I checked there's one version for
roaring.Another change I made is to switch from
<major>.<minor>.<patch>to<major>.<minor>;I do notice
cargois very good at figuring out a crate version which works for all or most dependency requirements.A precise version requirement is easy to lead to multiple versions for one single crate.
Are these changes tested?
No op change, CI should be enough.