feat(iceberg-datafusion): make IcebergTableScan public #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @colinmarc for this pr, generally LGTM! Just some minor suggestions.
8310d33 to
763d6aa
Compare
DataFusion `ExecutionPlan` implementations are usually public, so that they can be inspected and munged by optimization rules.
763d6aa to
81d1d4d
Compare
liurenjie1024
approved these changes
Aug 1, 2025
Contributor
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @colinmarc for this pr!
Yiyang-C
pushed a commit
to Yiyang-C/iceberg-rust
that referenced
this pull request
Aug 26, 2025
DataFusion `ExecutionPlan` implementations are generally public, so that they can be inspected and munged by optimization rules. Our specific use case is to use `IcebergTableProvider` to plan files, and then pass those files (assuming no deletes) to DataFusion`s `ListingTable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFusion
ExecutionPlanimplementations are generally public, so that they can be inspected and munged by optimization rules.Our specific use case is to use
IcebergTableProviderto plan files, and then pass those files (assuming no deletes) to DataFusionsListingTable`.