feat: append action allows snapshot properties #1534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @dentiny for this pr, generally LGTM!
| ) -> Result<Vec<ManifestFile>> { | ||
| let added_manifest = self.write_added_manifest().await?; | ||
| // Assert current snapshot producer contains new content to add to new snapshot. | ||
| if self.added_data_files.is_empty() && self.snapshot_properties.is_empty() { |
Contributor
There was a problem hiding this comment.
Please create an issue to track that we need to remove this workaround when we introduced all necessary tx apis.
Contributor
Author
There was a problem hiding this comment.
Sure! I created an issue to track: #1548
Also leave TODO items in the code along with the issue attached.
liurenjie1024
approved these changes
Jul 23, 2025
Contributor
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @dentiny for this pr, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
I have a real-world production requirement: I need the capability to add snapshot properties to a new snapshot, whether or not there's new data files appended at the same time.
In this PR, I tried to reuse the
FastAppendinterface, which allows people only added properties but not data files.I don't find other available interfaces at the moment.
Are these changes tested?
Unit tested added.