FINERACT-2293: Migrate client address module to new command pipeline#5657
Open
avivijay19 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2293: Migrate client address module to new command pipeline#5657avivijay19 wants to merge 1 commit intoapache:developfrom
avivijay19 wants to merge 1 commit intoapache:developfrom
Conversation
vidakovic
reviewed
Mar 20, 2026
...c/main/java/org/apache/fineract/portfolio/address/service/ClientAddressWriteServiceImpl.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Mar 20, 2026
...c/main/java/org/apache/fineract/portfolio/address/service/ClientAddressWriteServiceImpl.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Mar 20, 2026
...rovider/src/main/java/org/apache/fineract/portfolio/client/api/ClientAddressApiResource.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Mar 20, 2026
71d9801 to
602cd1a
Compare
602cd1a to
91c3b39
Compare
vidakovic
reviewed
Mar 22, 2026
| @Slf4j | ||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class ClientAddressCreateCommandHandler implements CommandHandler<ClientAddressRequest, ClientAddressCreateResponse> { |
Contributor
There was a problem hiding this comment.
How about ClientAddressCreateRequest?
vidakovic
reviewed
Mar 22, 2026
| @Retry(name = "commandClientAddressCreate", fallbackMethod = "fallback") | ||
| @Override | ||
| @Transactional | ||
| public ClientAddressCreateResponse handle(Command<ClientAddressRequest> command) { |
vidakovic
reviewed
Mar 22, 2026
| @Slf4j | ||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class ClientAddressUpdateCommandHandler implements CommandHandler<ClientAddressRequest, ClientAddressUpdateResponse> { |
Contributor
There was a problem hiding this comment.
ClientAddressUpdateRequest
vidakovic
reviewed
Mar 22, 2026
| import org.apache.fineract.portfolio.address.filter.ClientAddressSearchParam; | ||
|
|
||
| public interface AddressReadPlatformService { | ||
| public interface AddressReadService { |
Contributor
There was a problem hiding this comment.
How about ClientAddressReadService?
vidakovic
reviewed
Mar 22, 2026
| @Service | ||
| @RequiredArgsConstructor | ||
| public class AddressReadPlatformServiceImpl implements AddressReadPlatformService { | ||
| public class AddressReadServiceImpl implements AddressReadService { |
vidakovic
reviewed
Mar 22, 2026
| public interface ClientAddressWriteService { | ||
|
|
||
| CommandProcessingResult addClientAddress(Long clientId, Long addressTypeId, JsonCommand command); | ||
| ClientAddressCreateResponse createClientAddress(ClientAddressRequest request); |
Contributor
There was a problem hiding this comment.
We are not running out of disk space... even if the request classes for 2 different commands have exactly the same attributes... put them in 2 different classes... sometimes duplication is your friend... because next week someone will have the idea of adding something to the create command... or update... or both... and: the automatic handler selection won't work properly here.
vidakovic
reviewed
Mar 22, 2026
| resilience4j.retry.instances.commandCacheSwitch.exponential-backoff-multiplier=${FINERACT_COMMAND_CACHE_SWITCH_RETRY_EXPONENTIAL_BACKOFF_MULTIPLIER:2} | ||
| resilience4j.retry.instances.commandCacheSwitch.retryExceptions=${FINERACT_COMMAND_CACHE_SWITCH_RETRY_EXCEPTIONS:org.springframework.dao.ConcurrencyFailureException,org.eclipse.persistence.exceptions.OptimisticLockException,jakarta.persistence.OptimisticLockException,org.springframework.orm.jpa.JpaOptimisticLockingFailureException} | ||
|
|
||
| # client address |
Contributor
There was a problem hiding this comment.
not entirely sure why you just didn't move it to the end of last command, but before the general command related configs start... at the moment we are only 2 people working on this... so I guess it's fine... if we had more this would create some Git conflict chaos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.