Skip to content

Conversation

@ppchart
Copy link
Contributor

@ppchart ppchart commented Nov 2, 2022

No description provided.

@ppchart ppchart mentioned this pull request Nov 2, 2022
@robinv8
Copy link
Contributor

robinv8 commented Nov 2, 2022

@ppchart Upgrading the version of the dependent library may cause other problems, which needs to be handled internally by us

@ppchart
Copy link
Contributor Author

ppchart commented Nov 2, 2022

@robinv8 This PR should not be merged until dependencies are upgraded
#17

@robinv8
Copy link
Contributor

robinv8 commented Nov 2, 2022

revert #60

Let's discuss internally

@robinv8
Copy link
Contributor

robinv8 commented Nov 2, 2022

@ppchart You mentioned a PR that limits pnpm

@ppchart
Copy link
Contributor Author

ppchart commented Nov 2, 2022

#62

Submitted a PR that only supports pnpm. If we tell users that only pnpm is supported, the problem of the wrong version of react-router-dom after installing dependencies on npm can be ignored


提交了一个只支持 pnpm 的 PR,如果我们告诉用户只支持使用 pnpm,针对 npm 安装依赖后 react-router-dom 版本错误的问题就可以被忽略了

@robinv8 robinv8 closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants