fix function #160
Merged
fix function #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38daeeb to
3f5b06e
Compare
dsnam
reviewed
Oct 8, 2025
answer_rocket/layouts.py
Outdated
| 'id': id, | ||
| }) | ||
| try: | ||
| op = self._gql_client.query.get_dynamic_layout |
Contributor
There was a problem hiding this comment.
does this still work as expected? This is no longer using the generated operation created from the layouts.gql file. sometimes sgqlc does the magic thing and just requests all the fields when you don't specify anything, but this may end up with an empty query, can't remember which.
If you use what gets put into sdk_operations.Operations by the code gen those are already baked operations with all the operation.field_name() calls made for you by the code gen. If you use the query or mutation operation starters off the client you are starting from scratch.
22875e8 to
9e68303
Compare
dsnam
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forgot to import Operations