Update gcp_compute_disk.py #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
…nsible-collections#273) * add source_image to google_compute_image * add source_snapshot to google_compute_image * PR comment changes Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
* Add new field filter to pubsub. Fixes: hashicorp/terraform-provider-google#6727 * Fixed filter name, it was improperly set. * add filter key to pubsub subscription unit test * spaces not tabs! * hardcode filter value in test * revert remove escaped quotes Co-authored-by: Tim O'Connell <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Tim O'Connell <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
…llections#278) Add enableMessageOrdering to Pub/Sub Subscription Signed-off-by: Modular Magician <[email protected]>
* use {product}.googleapis.com endpoints
* use actual correct urls
* fix zone data source test
* fix network peering tests
* possibly fix deleting default network
Signed-off-by: Modular Magician <[email protected]>
…le-collections#280) * [provider-yaml] - Removed instances where input and output are both true * modified to only supply output. Following pattern from bigquerydatatransfer Co-authored-by: Scott Suarez <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Scott Suarez <[email protected]>
* retrypolicy attribute added * test case updated Signed-off-by: Modular Magician <[email protected]>
…nsible-collections#282) Co-authored-by: Dana Hoffman <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]>
…tions#283) Co-authored-by: Cameron Thornton <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Cameron Thornton <[email protected]>
This commit solve a problem that whe have been facing when trying to create a disk from a snashot. gcp_compute_module allow field sourceSnapshot but it's not sending to gcp api. Now you can pass selflink or gcp_compute_snapshot object and it will be sended correctly to gcp api.
|
is this patch still needed? I see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit solve a problem that whe have been facing when trying to create a disk from a snashot.
gcp_compute_module allow field sourceSnapshot but it's not sending to gcp api.
Now you can pass selflink or gcp_compute_snapshot object and it will be sended correctly to gcp api.
SUMMARY
Including sourceSnapshot field to the request and defining if selflink our gcp_compute_snapshot object.
Fixes old repo issue.
ansible/ansible#61635
ISSUE TYPE
COMPONENT NAME
gcp_compute_disk.py
ADDITIONAL INFORMATION
gcp_compute_disk module is not able to send sourceSnapshot to the gcp api, so it's impossible to create a disk from a snapshot created before.